netdev - Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL1RGDWBJr=D3sRyZTM4VxrPf+Dy35K1DRYCZW9OZSkbtZPhww@mail.gmail.com>
Date:	Fri, 2 Oct 2015 10:18:58 -0700
From:	Roland Dreier <roland@...estorage.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:	David Miller <davem@...emloft.net>, tgraf@...g.ch,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	wkok@...ulusnetworks.com, stable@...r.kernel.org
Subject: Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs

On Tue, Sep 22, 2015 at 9:40 PM, Roopa Prabhu <roopa@...ulusnetworks.com> wrote:
> +               err = fib_nl_fill_rule(skb, rule, NETLINK_CB(cb->skb).portid,
> +                                      cb->nlh->nlmsg_seq, RTM_NEWRULE,
> +                                      NLM_F_MULTI, ops);
> +               if (err)

FWIW I believe this breaks pre-4.0 stable kernels (unfortunately it
just showed up in 3.10.90).  In kernels without 053c095a82cf
("netlink: make nlmsg_end() and genlmsg_end() void") then
fib_nl_fill_rule() returns a positive value (skb->len) on success, so
we break out of the loop here immediately.  Symptom is "ip rule show"
loops forever printing the first rule.

After I finish testing a fix (as trivial as changing to "if (err <
0)") here, I'll send it to -stable guys.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html