netdev - Re: [PATCH] net ipv4 ipconfig: use preferred log methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150927223715.7364a1e1@urahara>
Date:	Sun, 27 Sep 2015 22:37:15 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Bastian Stender <bst@...gutronix.de>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	trivial@...nel.org, kernel@...gutronix.de
Subject: Re: [PATCH] net ipv4 ipconfig: use preferred log methods

On Fri, 25 Sep 2015 11:58:30 +0200
Bastian Stender <bst@...gutronix.de> wrote:

>  
>  #ifdef IPCONFIG_DEBUG
> -#define DBG(x) printk x
> +#define DBG(x) pr_debug(x)
>  #else
>  #define DBG(x) do { } while(0)
>  #endif

Why not remove all the local IPCONFIG_DEBUG stuff and just use pr_debug()
like modern kernel code.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html