netdev - Re: [PATCH] net ipv4 ipconfig: use preferred log methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150928.222409.1641594777817922710.davem@davemloft.net>
Date:	Mon, 28 Sep 2015 22:24:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bst@...gutronix.de
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, netdev@...r.kernel.org, trivial@...nel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH] net ipv4 ipconfig: use preferred log methods

From: Bastian Stender <bst@...gutronix.de>
Date: Fri, 25 Sep 2015 11:58:30 +0200

> @@ -69,7 +69,7 @@
>  #undef IPCONFIG_DEBUG
>  
>  #ifdef IPCONFIG_DEBUG
> -#define DBG(x) printk x
> +#define DBG(x) pr_debug(x)
>  #else
>  #define DBG(x) do { } while(0)
>  #endif

I agree with Stephen, just get rid of this and use pr_debug()
unconditionally.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html