netdev - Re: [PATCH] net/mlx4: Handle return codes in mlx4_qp_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150928.222642.1395622340146984028.davem@davemloft.net>
Date:	Mon, 28 Sep 2015 22:26:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rmanes@...hat.com
Cc:	netdev@...r.kernel.org, amirv@...lanox.com, eyalpe@...lanox.com,
	ogerlitz@...lanox.com
Subject: Re: [PATCH] net/mlx4: Handle return codes in mlx4_qp_attach_common

From: Robb Manes <rmanes@...hat.com>
Date: Fri, 25 Sep 2015 10:39:21 -0400

> @@ -1184,10 +1184,11 @@ out:
>      if (prot == MLX4_PROT_ETH) {
>          /* manage the steering entry for promisc mode */
>          if (new_entry)
> -            new_steering_entry(dev, port, steer, index, qp->qpn);
> +            err = new_steering_entry(dev, port, steer,
> +                         index, qp->qpn);
>          else
> -            existing_steering_entry(dev, port, steer,
> -                        index, qp->qpn);
> +            err = existing_steering_entry(dev, port, steer,
> +                              index, qp->qpn);

Please indent this properly.

When a function call spans multiple lines, the second and
subsequent lines must start precisely at the first column
after the openning parenthesis of the first line.  You must
use the appropriate number of TAB then SPACE characters
necessary to achieve this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html