netdev - Re: [PATCH net-next] dsa: mv88e6xxx: Fix unsigned/signed issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150929.211318.1846763983800250099.davem@davemloft.net>
Date:	Tue, 29 Sep 2015 21:13:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andrew@...n.ch
Cc:	netdev@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH net-next] dsa: mv88e6xxx: Fix unsigned/signed issue

From: Andrew Lunn <andrew@...n.ch>
Date: Tue, 29 Sep 2015 01:53:48 +0200

> commit dea870242a9c ("dsa: mv88e6xxx: Allow speed/duplex of port to be
> configured") leads to the following static checker warning:
> 
>         drivers/net/dsa/mv88e6xxx.c:585 mv88e6xxx_adjust_link()
>         warn: unsigned 'ret' is never less than zero.
> 
> drivers/net/dsa/mv88e6xxx.c
>    573  void mv88e6xxx_adjust_link(struct dsa_switch *ds, int port,
>    574                             struct phy_device *phydev)
>    575  {
>    576          struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
>    577          u32 ret, reg;
>    578
>    579          if (!phy_is_pseudo_fixed_link(phydev))
>    580                  return;
>    581
>    582          mutex_lock(&ps->smi_mutex);
>    583
>    584          ret = _mv88e6xxx_reg_read(ds, REG_PORT(port), PORT_PCS_CTRL);
>    585          if (ret < 0)
> 
> Make ret an int, which is the return type for _mv88e6xxx_reg_read()
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html