netdev - Re: [PATCH v2] net/mlx4: Handle return codes in mlx4_qp_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150929.211544.2010703361386126834.davem@davemloft.net>
Date:	Tue, 29 Sep 2015 21:15:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rmanes@...hat.com
Cc:	netdev@...r.kernel.org, amirv@...lanox.com, eyalpe@...lanox.com,
	ogerlitz@...lanox.com
Subject: Re: [PATCH v2] net/mlx4: Handle return codes in
 mlx4_qp_attach_common

From: Robb Manes <rmanes@...hat.com>
Date: Tue, 29 Sep 2015 11:03:37 -0400

> Both new_steering_entry() and existing_steering_entry() return values
> based on their success or failure, but currently they fall through
> silently.  This can make troubleshooting difficult, as we were unable
> to tell which one of these two functions returned errors or
> specifically what code was returned.  This patch remedies that
> situation by passing the return codes to err, which is returned by
> mlx4_qp_attach_common() itself.
> 
> This also addresses a leak in the call to mlx4_bitmap_free() as well.
> 
> Signed-off-by: Robb Manes <rmanes@...hat.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html