netdev - Re: [PATCH net-next] tcp/dccp: add SLAB_DESTROY_BY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151003.132544.1489547849171491402.davem@davemloft.net>
Date:	Sat, 03 Oct 2015 13:25:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp/dccp: add SLAB_DESTROY_BY_RCU flag for
 request sockets

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 03 Oct 2015 06:27:28 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Before letting request sockets being put in TCP/DCCP regular
> ehash table, we need to add either :
> 
> - SLAB_DESTROY_BY_RCU flag to their kmem_cache
> - add RCU grace period before freeing them.
> 
> Since we carefully respected the SLAB_DESTROY_BY_RCU protocol
> like ESTABLISH and TIMEWAIT sockets, use it here.
> 
> req_prot_init() being only used by TCP and DCCP, I did not add
> a new slab_flags into their rsk_prot, but reuse prot->slab_flags
> 
> Since all reqsk_alloc() users are correctly dealing with a failure,
> add the __GFP_NOWARN flag to avoid traces under pressure.
> 
> Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html