netdev - Re: [PATCH] net: dsa: better error reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5610378B.4020009@gmail.com>
Date:	Sat, 3 Oct 2015 13:16:11 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Russell King <rmk+kernel@....linux.org.uk>, netdev@...r.kernel.org
Cc:	Andrew Lunn <andrew@...n.ch>, Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] net: dsa: better error reporting

Le 03/10/2015 10:09, Russell King a écrit :
> Add additional error reporting to the generic DSA code, so it's easier
> to debug when things go wrong.  This was useful when initially bringing
> up 88e6176 on a new board.
> 
> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> ---

[snip]

>  	} else {
>  		netdev_info(slave_dev, "attached PHY at address %d [%s]\n",
>  			    p->phy->addr, p->phy->drv->name);
> @@ -1195,6 +1202,7 @@ int dsa_slave_create(struct dsa_switch *ds, struct device *parent,
>  
>  	ret = dsa_slave_phy_setup(p, slave_dev);
>  	if (ret) {
> +		netdev_err(master, "error %d setting up slave phy\n", ret);
>  		free_netdev(slave_dev);
>  		return ret;

All of these debug messages are going to happen prior to the slave
network device being registered, so you would get these error messages
to be printed with an extraneous " (unregistered)" which is fine, just a
tad annoying sometimes.

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html