netdev - Re: [PATCH] bridge/netfilter: avoid unused label warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Oct 2015 23:02:45 +0200
From:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:	Arnd Bergmann <arnd@...db.de>, linux-arm-kernel@...ts.infradead.org
Cc:	netdev@...r.kernel.org, Florian Westphal <fw@...len.de>,
	linux-kernel@...r.kernel.org,
	Pablo Neira Ayuso <pablo@...filter.org>,
	David Miller <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH] bridge/netfilter: avoid unused label warning

On 10/06/2015 09:39 PM, Arnd Bergmann wrote:
> On Tuesday 06 October 2015 21:28:29 Nikolay Aleksandrov wrote:
>> I posted a fix for this a couple of days ago, but I like your approach better.
>> Since mine is not yet applied (I sent it to netfilter-devel only, wasn't sure which
>> jurisdiction this falls into exactly) we can drop it.
>> Just for reference my patch is here:
>> http://patchwork.ozlabs.org/patch/526417/
>> Pablo, could you please drop it ?
>>
>> By the way this takes care of another warning about unused variable (nf_bridge), too.
> 
> Hmm I did not get that one, at least not in 4.3-rc4.
> 
You need to set W=1
$ git describe --abbrev=0
v4.3-rc4

net/bridge//br_netfilter_hooks.c: In function ‘br_nf_dev_queue_xmit’:
net/bridge//br_netfilter_hooks.c:794:2: warning: label ‘drop’ defined but not used [-Wunused-label]
  drop:
  ^
net/bridge//br_netfilter_hooks.c:727:25: warning: variable ‘nf_bridge’ set but not used [-Wunused-but-set-variable]
  struct nf_bridge_info *nf_bridge;

Cheers,
 Nik

>> Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> Thanks and sorry for missing the Cc to the netfilter list on my patch.
> 
> 	Arnd


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html