netdev - Re: [PATCH v3 2/2] ne: DeviceTree support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201510081604.nmlmcbcu%fengguang.wu@intel.com>
Date:	Thu, 8 Oct 2015 16:43:09 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Yoshinori Sato <ysato@...rs.sourceforge.jp>
Cc:	kbuild-all@...org, netdev@...r.kernel.org,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>
Subject: Re: [PATCH v3 2/2] ne: DeviceTree support.

Hi Yoshinori,

[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore]

config: m68k-multi_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/8390/ne.c: In function 'ne_drv_probe':
>> drivers/net/ethernet/8390/ne.c:817:6: warning: passing argument 1 of 'dev_of_node' from incompatible pointer type
     if (dev_of_node(dev))
         ^
   In file included from include/linux/pnp.h:11:0,
                    from include/linux/isapnp.h:26,
                    from drivers/net/ethernet/8390/ne.c:47:
   include/linux/device.h:967:35: note: expected 'struct device *' but argument is of type 'struct net_device *'
    static inline struct device_node *dev_of_node(struct device *dev)
                                      ^
   drivers/net/ethernet/8390/ne.c:818:24: warning: passing argument 1 of 'dev_of_node' from incompatible pointer type
      of_property_read_u32(dev_of_node(dev),
                           ^
   In file included from include/linux/pnp.h:11:0,
                    from include/linux/isapnp.h:26,
                    from drivers/net/ethernet/8390/ne.c:47:
   include/linux/device.h:967:35: note: expected 'struct device *' but argument is of type 'struct net_device *'
    static inline struct device_node *dev_of_node(struct device *dev)
                                      ^

vim +/dev_of_node +817 drivers/net/ethernet/8390/ne.c

   801			}
   802	
   803		outb_p(ENISR_RDC, nic_base + EN0_ISR);	/* Ack intr. */
   804		ei_status.dmaing &= ~0x01;
   805	}
   806	
   807	static int __init ne_drv_probe(struct platform_device *pdev)
   808	{
   809		struct net_device *dev;
   810		int err, this_dev = pdev->id;
   811		struct resource *res;
   812	
   813		dev = alloc_eip_netdev();
   814		if (!dev)
   815			return -ENOMEM;
   816	
 > 817		if (dev_of_node(dev))
   818			of_property_read_u32(dev_of_node(dev),
   819					     "national,dcr", &of_dcr_val);
   820	
   821		/* ne.c doesn't populate resources in platform_device, but
   822		 * rbtx4927_ne_init and rbtx4938_ne_init do register devices
   823		 * with resources.
   824		 */
   825		res = platform_get_resource(pdev, IORESOURCE_IO, 0);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (12569 bytes)