netdev - Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1444293021.2899.46.camel@intel.com>
Date:	Thu, 8 Oct 2015 08:30:22 +0000
From:	"Coelho, Luciano" <luciano.coelho@...el.com>
To:	"xerofoify@...il.com" <xerofoify@...il.com>,
	"Berg, Johannes" <johannes.berg@...el.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Spinadel, David" <david.spinadel@...el.com>,
	"Dreyfuss, Haim" <haim.dreyfuss@...el.com>,
	"Bondar, Alexander" <alexander.bondar@...el.com>,
	"ilw@...ux.intel.com" <ilw@...ux.intel.com>,
	"kvalo@...eaurora.org" <kvalo@...eaurora.org>,
	"Stern, Avraham" <avraham.stern@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>
Subject: Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement
 in the function iwl_mvm_check_running_scans

On Tue, 2015-09-22 at 20:24 -0400, Nicholas Krause wrote:
> This fixes incorrect fallthrough in the switch statment checking
> the scan type passed by the caller to iwl_mvm_check_running_scans
> for the switch case IWL_MVM_SCAN_SCHED to return directly after
> the call to iwl_mvm_scan_stop in order to avoid fallthrough into
> the next case and incorrectly return zero indicating success to
> the caller even if the function call to iwl_mvm_scan_stop fails.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---

Applied to our internal tree with a modified commit message.

Thanks!

--
Luca.