netdev - Re: [PATCH net-next] route: fib_validate_source remove the <= RT_SCOPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Oct 2015 01:25:39 +0800
From:	lucien xin <lucien.xin@...il.com>
To:	Julian Anastasov <ja@....bg>
Cc:	network dev <netdev@...r.kernel.org>, davem <davem@...emloft.net>,
	fw@...len.de
Subject: Re: [PATCH net-next] route: fib_validate_source remove the <=
 RT_SCOPE_HOST test

On Wed, Oct 14, 2015 at 3:24 AM, Julian Anastasov <ja@....bg> wrote:
>
>         Hello,
>
> On Wed, 14 Oct 2015, Xin Long wrote:
>
>> commit fe3edf45792a ("ipv4: Remove all RTCF_DIRECTSRC handliing.").
>>
>> Before this commit, we had a tristate:
>> < 0: error
>> 0: ok
>> 1: ok and set RTCF_DIRECTSRC
>>
>> But now we only care about 0 or < 0.
>
>         Not true, __mkroute_input() uses the 'err' result
> to set IPSKB_DOREDIRECT.
>
yeah, I don't understand why err > 0 is necessary to set IPSKB_DOREDIRECT
to send redirects.
FIB_RES_NH(res).nh_scope >= RT_SCOPE_HOST, what's that mean?

> Regards
>
> --
> Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html