netdev - Re: [PATCH net-next] drivers/net: get rid of unnecessary initializations in .get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Oct 2015 01:17:41 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Ivan Vecera <ivecera@...hat.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org, bwh@...nel.org
Subject: Re: [PATCH net-next] drivers/net: get rid of unnecessary
 initializations in .get_drvinfo()

Hi Ivan,

[auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Ivan-Vecera/drivers-net-get-rid-of-unnecessary-initializations-in-get_drvinfo/20151015-002923
config: i386-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/net/usb/sr9800.c: In function 'sr_get_drvinfo':
>> drivers/net/usb/sr9800.c:474:18: warning: unused variable 'data' [-Wunused-variable]
     struct sr_data *data = (struct sr_data *)&dev->data;
                     ^

vim +/data +474 drivers/net/usb/sr9800.c

19a38d8e Liu Junliang 2014-02-10  458  	eeprom->magic = SR_EEPROM_MAGIC;
19a38d8e Liu Junliang 2014-02-10  459  
19a38d8e Liu Junliang 2014-02-10  460  	/* sr9800 returns 2 bytes from eeprom on read */
19a38d8e Liu Junliang 2014-02-10  461  	for (i = 0; i < eeprom->len / 2; i++) {
19a38d8e Liu Junliang 2014-02-10  462  		ret = sr_read_cmd(dev, SR_CMD_READ_EEPROM, eeprom->offset + i,
19a38d8e Liu Junliang 2014-02-10  463  				  0, 2, &ebuf[i]);
19a38d8e Liu Junliang 2014-02-10  464  		if (ret < 0)
19a38d8e Liu Junliang 2014-02-10  465  			return -EINVAL;
19a38d8e Liu Junliang 2014-02-10  466  	}
19a38d8e Liu Junliang 2014-02-10  467  	return 0;
19a38d8e Liu Junliang 2014-02-10  468  }
19a38d8e Liu Junliang 2014-02-10  469  
19a38d8e Liu Junliang 2014-02-10  470  static void sr_get_drvinfo(struct net_device *net,
19a38d8e Liu Junliang 2014-02-10  471  				 struct ethtool_drvinfo *info)
19a38d8e Liu Junliang 2014-02-10  472  {
19a38d8e Liu Junliang 2014-02-10  473  	struct usbnet *dev = netdev_priv(net);
19a38d8e Liu Junliang 2014-02-10 @474  	struct sr_data *data = (struct sr_data *)&dev->data;
19a38d8e Liu Junliang 2014-02-10  475  
19a38d8e Liu Junliang 2014-02-10  476  	/* Inherit standard device info */
19a38d8e Liu Junliang 2014-02-10  477  	usbnet_get_drvinfo(net, info);
19a38d8e Liu Junliang 2014-02-10  478  	strncpy(info->driver, DRIVER_NAME, sizeof(info->driver));
19a38d8e Liu Junliang 2014-02-10  479  	strncpy(info->version, DRIVER_VERSION, sizeof(info->version));
19a38d8e Liu Junliang 2014-02-10  480  }
19a38d8e Liu Junliang 2014-02-10  481  
19a38d8e Liu Junliang 2014-02-10  482  static u32 sr_get_link(struct net_device *net)

:::::: The code at line 474 was first introduced by commit
:::::: 19a38d8e0aa33b4f4d11d3b4baa902ad169daa80 USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support

:::::: TO: Liu Junliang <liujunliang_ljl@....com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (51645 bytes)