netdev - Re: [PATCH net-next] drivers/net: get rid of unnecessary initializations in .get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Oct 2015 19:08:31 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Ivan Vecera <ivecera@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] drivers/net: get rid of unnecessary
 initializations in .get_drvinfo()

On Wed, 2015-10-14 at 18:27 +0200, Ivan Vecera wrote:
> Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
> eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
> It's not necessary as these fields is filled in ethtool_get_drvinfo().
> 
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
[...]

Acked-by: Ben Hutchings <ben@...adent.org.uk>

-- 
Ben Hutchings
[W]e found...that it wasn't as easy to get programs right as we had thought.
... I realized that a large part of my life from then on was going to be spent
in finding mistakes in my own programs. - Maurice Wilkes, 1949
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)