netdev - Re: [PATCH 2/2] isdn: correctly check failed allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <561FF37C.7070107@linux-pingi.de>
Date:	Thu, 15 Oct 2015 20:42:04 +0200
From:	isdn@...ux-pingi.de
To:	Insu Yun <wuninsu@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	taesoo@...ech.edu, yeongjin.jang@...ech.edu, insu@...ech.edu
Subject: Re: [PATCH 2/2] isdn: correctly check failed allocation

Hi Insu,

thanks for bringing up this issue again.
I thought I did fix this a year ago, but seems it did not managed to
sent it upstream.

The patch do not fix this completly, since it will drop the original skb
from the L2 I frame queue, so the transmission would lost an I-FRAME,
which is not allowed by the protocol.

The format of the new lines is wrong, you need to use TAB.


Best regards
Karsten

Am 15.10.2015 um 18:29 schrieb Insu Yun:
> Since skb_clone is memory allocation, it could be failed when lack of resource.
> Therefore, return value of skb_clone needs to be checked and handle error.
> 
> Signed-off-by: Insu Yun <wuninsu@...il.com>
> ---
>  drivers/isdn/mISDN/layer2.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
> index 949cabb..888c610 100644
> --- a/drivers/isdn/mISDN/layer2.c
> +++ b/drivers/isdn/mISDN/layer2.c
> @@ -1509,6 +1509,12 @@ l2_pull_iqueue(struct FsmInst *fi, int event, void *arg)
>  	}
>  
>  	nskb = skb_clone(skb, GFP_ATOMIC);
> +  if (!nskb) {
> +			printk(KERN_WARNING "%s: no skb mem in %s\n",
> +			       mISDNDevName4ch(&l2->ch), __func__);
> +			return;
> +  }
> +
>  	p1 = skb_headroom(nskb);
>  	if (p1 >= i)
>  		memcpy(skb_push(nskb, i), header, i);
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html