netdev - Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1444934818.25595.9.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 15 Oct 2015 11:46:58 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
Cc:	Nikolay Borisov <kernel@...p.com>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	David Miller <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	operations@...eground.com
Subject: Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in
 atomic context

On Thu, 2015-10-15 at 20:25 +0200, Jozsef Kadlecsik wrote:

> Nikolay answered this pretty well: we wouldn't need the spinlock at all, 
> because all commands are serialized anyway with the netlink mutex. But the 
> garbage collector is called by a timer and therefore spinlock is used.
> 

Good, please Nikolay, send a v2 of the patch with all these details
explained in the changelog, so that we can all agree.

If properly explained, no need to add the stack trace which does not
really tell us the story.

Thanks !



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html