netdev - Re: [PATCH v8 net-next 2/2] bonding: Simplify the xmit function for modes that use xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Oct 2015 11:01:24 -0700
From:	Mahesh Bandewar <maheshb@...gle.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Veaceslav Falico <vfalico@...il.com>,
	Nikolay Aleksandrov <nikolay@...hat.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Maciej Zenczykowski <maze@...gle.com>
Subject: Re: [PATCH v8 net-next 2/2] bonding: Simplify the xmit function for
 modes that use xmit_hash

On Mon, Oct 19, 2015 at 9:35 AM, Jiri Pirko <jiri@...nulli.us> wrote:
> Sun, Oct 05, 2014 at 02:45:01AM CEST, maheshb@...gle.com wrote:
>>Earlier change to use usable slave array for TLB mode had an additional
>>performance advantage. So extending the same logic to all other modes
>>that use xmit-hash for slave selection (viz 802.3AD, and XOR modes).
>>Also consolidating this with the earlier TLB change.
>>
>>The main idea is to build the usable slaves array in the control path
>>and use that array for slave selection during xmit operation.
>>
>>Measured performance in a setup with a bond of 4x1G NICs with 200
>>instances of netperf for the modes involved (3ad, xor, tlb)
>>cmd: netperf -t TCP_RR -H <TargetHost> -l 60 -s 5
>>
>>Mode        TPS-Before   TPS-After
>>
>>802.3ad   : 468,694      493,101
>>TLB (lb=0): 392,583      392,965
>>XOR       : 475,696      484,517
>
> Looking over bonding code now and came across this commit. It gave me a
> little headache. Why don't you guys just use team instead of doing
> bonding megapatches like this? This is making bonding code even more
> complicated (screwed-up) :/ I don't understand.

Why are you looking at bonding to have headache in first place go use team. ;)

The commit message was very clear about the intention and the purpose
is to avoid list-traversal cost in fast path for modes that use
xmit-hash. If you feel something is screwed-up please send a patch to
fix it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html