netdev - Fw: [Bug 106351] New: error in upstream commit 41fc014332d91ee90c32840bf161f9685b7fbf2b fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20151021090246.11afdf26@xeon-e3>
Date:	Wed, 21 Oct 2015 09:02:46 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	netdev@...r.kernel.org
Subject: Fw: [Bug 106351] New: error in upstream commit
 41fc014332d91ee90c32840bf161f9685b7fbf2b fib_rules:...

Begin forwarded message:

Date: Tue, 20 Oct 2015 12:20:39 +0000
From: "bugzilla-daemon@...zilla.kernel.org" <bugzilla-daemon@...zilla.kernel.org>
To: "shemminger@...ux-foundation.org" <shemminger@...ux-foundation.org>
Subject: [Bug 106351] New: error in upstream commit 41fc014332d91ee90c32840bf161f9685b7fbf2b fib_rules:...

https://bugzilla.kernel.org/show_bug.cgi?id=106351

            Bug ID: 106351
           Summary: error in upstream commit
                    41fc014332d91ee90c32840bf161f9685b7fbf2b fib_rules:...
           Product: Networking
           Version: 2.5
    Kernel Version: 3.14
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Other
          Assignee: shemminger@...ux-foundation.org
          Reporter: m.koenigshaus@....de
        Regression: No

Hi,
upstream commit 41fc014332d91ee90c32840bf161f9685b7fbf2b has a small flaw.
Before the patch, the loop in dump_rules (line 627 - 638, fib_rules.c) was
canceled if fib_nl_fill_rule returns a value less than zero, after the patch it
is canceled if fib_nl_fill_rule returns a nonzero value. But without errors
fib_nl_fill_rule will return skb-> len. So I thing the termination condition
should be "if (err < 0) break;" not "if (err) break;".
This error leads to OOM - Exceptions in our system with program "ip"! After
changing the code to "if (err < 0) break;" everything works fine.

Regards, Markus

-- 
You are receiving this mail because:
You are the assignee for the bug.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html