netdev - Re: [PATCH 10/11] net: ipv4: hlen could be set as size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151023.060852.167547226456492975.davem@davemloft.net>
Date:	Fri, 23 Oct 2015 06:08:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	clabbe.montjoie@...il.com
Cc:	jmorris@...ei.org, kaber@...sh.net, kuznet@....inr.ac.ru,
	yoshfuji@...ux-ipv6.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 10/11] net: ipv4: hlen could be set as size_t

From: LABBE Corentin <clabbe.montjoie@...il.com>
Date: Fri, 23 Oct 2015 14:10:35 +0200

> The hlen member of raw_frag_vec is used in operation/function that wait
> for unsigned value. So it need to be set as size_t.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>

You really need to test your changes.

Particularly on a platform where size_t has a different size than
'int'.  That will generate several warnings, as shown by all of the
build warning reports sent by the kbuild test robot in response to
this patch series.

Also, you need to CC: all relevant mailing lists for the entire series
of patches, and also provide a "Subject: [PATCH 0/N] xxx" posting
describing at a high level and in detail what this patch series is
doing, and why.

It should also clearly state what exact tree you expect these patches
to be merged into.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html