[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151023132100.GA16922@Red>
Date: Fri, 23 Oct 2015 15:21:00 +0200
From: LABBE Corentin <clabbe.montjoie@...il.com>
To: David Miller <davem@...emloft.net>
Cc: jmorris@...ei.org, kaber@...sh.net, kuznet@....inr.ac.ru,
yoshfuji@...ux-ipv6.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH 10/11] net: ipv4: hlen could be set as size_t
On Fri, Oct 23, 2015 at 06:08:52AM -0700, David Miller wrote:
> From: LABBE Corentin <clabbe.montjoie@...il.com>
> Date: Fri, 23 Oct 2015 14:10:35 +0200
>
> > The hlen member of raw_frag_vec is used in operation/function that wait
> > for unsigned value. So it need to be set as size_t.
> >
> > Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>
>
> You really need to test your changes.
>
> Particularly on a platform where size_t has a different size than
> 'int'. That will generate several warnings, as shown by all of the
> build warning reports sent by the kbuild test robot in response to
> this patch series.
>
> Also, you need to CC: all relevant mailing lists for the entire series
> of patches, and also provide a "Subject: [PATCH 0/N] xxx" posting
> describing at a high level and in detail what this patch series is
> doing, and why.
>
> It should also clearly state what exact tree you expect these patches
> to be merged into.
>
> Thanks.
Hello
I am sorry, I have badly checked my build logs.
I have added all mailing list given by get_maintainer but this was done per patch with --to-cmd/--cc-cmd
Does it is better to put all mailing list globally ?
For the (0/N) mail, I forgot to add a subject on it https://lkml.org/lkml/2015/10/23/219
I will fix all minor finding and resend a proper version.
Thanks
LABBE Corentin
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists