netdev - Re: [PATCHv2 net 1/3] openvswitch: Fix double-free on ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151024082025.GB19055@breakpoint.cc>
Date:	Sat, 24 Oct 2015 10:20:25 +0200
From:	Florian Westphal <fw@...len.de>
To:	Joe Stringer <joestringer@...ira.com>
Cc:	netdev@...r.kernel.org, Florian Westphal <fw@...len.de>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Andy Zhou <azhou@...ira.com>
Subject: Re: [PATCHv2 net 1/3] openvswitch: Fix double-free on ip_defrag()
 errors

Joe Stringer <joestringer@...ira.com> wrote:
>  err:
> +	if (err)
> +		kfree_skb(skb);
>  	skb_push(skb, nh_ofs);

That looks... wrong :-}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html