netdev - Re: [PATCHv2 net 1/3] openvswitch: Fix double-free on ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANr6G5wZ5DKmgpEmkaL2ytUuUbZoye_0XSE6UK1KOfKYDD--=Q@mail.gmail.com>
Date:	Sat, 24 Oct 2015 11:43:16 -0700
From:	Joe Stringer <joestringer@...ira.com>
To:	Florian Westphal <fw@...len.de>
Cc:	Linux Netdev List <netdev@...r.kernel.org>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Andy Zhou <azhou@...ira.com>
Subject: Re: [PATCHv2 net 1/3] openvswitch: Fix double-free on ip_defrag() errors

On 24 October 2015 at 01:20, Florian Westphal <fw@...len.de> wrote:
> Joe Stringer <joestringer@...ira.com> wrote:
>>  err:
>> +     if (err)
>> +             kfree_skb(skb);
>>       skb_push(skb, nh_ofs);
>
> That looks... wrong :-}

D'oh. Teaches me for last minute adjustments. I'll resend.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html