netdev - Re: [RFC PATCH net-next] tipc: tipc_link_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151026011322.GA26877@wfg-t540p.sh.intel.com>
Date:	Mon, 26 Oct 2015 09:13:22 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	kbuild-all@...org, netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-next] tipc: tipc_link_is_active() can be static

On Sun, Oct 25, 2015 at 06:33:18AM -0700, David Miller wrote:
> From: kbuild test robot <fengguang.wu@...el.com>
> Date: Sat, 24 Oct 2015 23:11:00 +0800
> 
> > TO: "David S. Miller" <davem@...emloft.net>
> > CC: netdev@...r.kernel.org
> > CC: Jon Maloy <jon.maloy@...csson.com>
> > CC: Ying Xue <ying.xue@...driver.com>
> > CC: tipc-discussion@...ts.sourceforge.net
> > CC: linux-kernel@...r.kernel.org
> > 
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> 
> Why doesn't the kbuild robot run on it's own changes? :-/

It does, however it detects only build failures (which indicates a
false sparse warning) to avoid sending bad make-it-static patch
and the false warning.

The build warning looks easier to be discovered and fixed in the
larger loop of

        apply patch => git push => 0day build test

>   CC [M]  net/tipc/link.o
> net/tipc/link.c:176:12: warning: ‘tipc_link_is_active’ defined but not used [-Wunused-function]

If the robot detected the above warning, it'll still need to send the
report out. Otherwise we lose a chance to notice tipc_link_is_active()
is not used.

However it may be valuable to include possible new warnings inside
the patch changelog, so that maintainers can immediately see the
consequences of applying the patch.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html