netdev - Re: [PATCHv3 net 1/3] openvswitch: Fix double-free on ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151027.193240.2120617002975981873.davem@davemloft.net>
Date:	Tue, 27 Oct 2015 19:32:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joestringer@...ira.com
Cc:	netdev@...r.kernel.org, fw@...len.de, pablo@...filter.org,
	azhou@...ira.com
Subject: Re: [PATCHv3 net 1/3] openvswitch: Fix double-free on ip_defrag()
 errors

From: Joe Stringer <joestringer@...ira.com>
Date: Sun, 25 Oct 2015 20:21:48 -0700

> If ip_defrag() returns an error other than -EINPROGRESS, then the skb is
> freed. When handle_fragments() passes this back up to
> do_execute_actions(), it will be freed again. Prevent this double free
> by never freeing the skb in do_execute_actions() for errors returned by
> ovs_ct_execute. Always free it in ovs_ct_execute() error paths instead.
> 
> Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
> Reported-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Joe Stringer <joestringer@...ira.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html