netdev - Re: [PATCHv3 net 3/3] openvswitch: Fix skb leak using IPv6 defrag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151027.193259.1057135403867772523.davem@davemloft.net>
Date:	Tue, 27 Oct 2015 19:32:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joestringer@...ira.com
Cc:	netdev@...r.kernel.org, fw@...len.de, pablo@...filter.org,
	azhou@...ira.com
Subject: Re: [PATCHv3 net 3/3] openvswitch: Fix skb leak using IPv6 defrag

From: Joe Stringer <joestringer@...ira.com>
Date: Sun, 25 Oct 2015 20:21:50 -0700

> nf_ct_frag6_gather() makes a clone of each skb passed to it, and if the
> reassembly is successful, expects the caller to free all of the original
> skbs using nf_ct_frag6_consume_orig(). This call was previously missing,
> meaning that the original fragments were never freed (with the exception
> of the last fragment to arrive).
> 
> Fix this by ensuring that all original fragments except for the last
> fragment are freed via nf_ct_frag6_consume_orig(). The last fragment
> will be morphed into the head, so it must not be freed yet. Furthermore,
> retain the ->next pointer for the head after skb_morph().
> 
> Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
> Reported-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Joe Stringer <joestringer@...ira.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html