netdev - Re: [PATCH net] sfc: push partner queue for skb->xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151102.230352.950957445475330532.davem@davemloft.net>
Date:	Mon, 02 Nov 2015 23:03:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mhabets@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH net] sfc: push partner queue for skb->xmit_more

From: Martin Habets <mhabets@...arflare.com>
Date: Mon, 2 Nov 2015 12:51:31 +0000

> When the IP stack passes SKBs the sfc driver puts them in 2 different TX
> queues (called partners), one for checksummed and one for not checksummed.
> If the SKB has xmit_more set the driver will delay pushing the work to the
> NIC.
> 
> When later it does decide to push the buffers this patch ensures it also
> pushes the partner queue, if that also has any delayed work. Before this
> fix the work in the partner queue would be left for a long time and cause
> a netdev watchdog.
> 
> Fixes: 70b33fb ("sfc: add support for skb->xmit_more")
> 
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Signed-off-by: Martin Habets <mhabets@...arflare.com>

Please do not separate the Fixes: tag from the other tags with an
empty line.  They should all solidly be together in an uninterrupted
block of text.

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html