netdev - Re: [PATCH net-next] mpls: Don't accept multipath configuration until the support is complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5638BE96.2010700@cumulusnetworks.com>
Date:	Tue, 03 Nov 2015 06:03:02 -0800
From:	roopa <roopa@...ulusnetworks.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	David Miller <davem@...emloft.net>, rshearma@...cade.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] mpls: Don't accept multipath configuration until
 the support is complete

On 11/2/15, 10:09 PM, Eric W. Biederman wrote:
> Sergei Shtylyov <sergei.shtylyov@...entembedded.com> writes:
>
>> Hello.
>>> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
>>> index c70d750148b6..893cd2dc3979 100644
>>> --- a/net/mpls/af_mpls.c
>>> +++ b/net/mpls/af_mpls.c
>>> @@ -1162,6 +1162,8 @@ static int rtm_to_route_config(struct sk_buff *skb,  struct nlmsghdr *nlh,
>>>   		{
>>>   			cfg->rc_mp = nla_data(nla);
>>>   			cfg->rc_mp_len = nla_len(nla);
>>> +			/* Fail until multipath support is complete */
>>> +			goto errout;
>>>   			break;
>>    Forgot to delete *break*?
> Nope.  I did that deliberately, because this code is not supposed to
> stay this way for long.
Eric, this is only until dead route support is added correct ?.
If yes, then my v2 on dead route/nh support is out. I know david is only taking bug fixes right now...
and I thought the dead route/nh is a bug fix. If you are ok with v2, we could skip this patch ?.

If david decides to not pick it up in net-next, i was hoping to submit it as a bug-fix to net.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html