netdev - Re: [PATCH] net/core: use netdev name in warning if no parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151116.162221.1821905374061673605.davem@davemloft.net>
Date:	Mon, 16 Nov 2015 16:22:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bjorn@...k.no
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net/core: use netdev name in warning if no parent

From: Bjørn Mork <bjorn@...k.no>
Date: Mon, 16 Nov 2015 19:16:40 +0100

> A recent flaw in the netdev feature setting resulted in warnings
> like this one from VLAN interfaces:
> 
>  WARNING: CPU: 1 PID: 4975 at net/core/dev.c:2419 skb_warn_bad_offload+0xbc/0xcb()
>  : caps=(0x00000000001b5820, 0x00000000001b5829) len=2782 data_len=0 gso_size=1348 gso_type=16 ip_summed=3
> 
> The ":" is supposed to be preceded by a driver name, but in this
> case it is an empty string since the device has no parent.
> 
> There are many types of network devices without a parent. The
> anonymous warnings for these devices can be hard to debug.  Log
> the network device name instead in these cases to assist further
> debugging.
> 
> This is mostly similar to how __netdev_printk() handles orphan
> devices.
> 
> Signed-off-by: Bjørn Mork <bjorn@...k.no>

Yeah that seems reasonable, applied, thanks!

I wonder if we open-code this in a lot of other places, and
therefore this deserves a helper and some auditing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html