netdev - RE: [PATCH] net/core: use netdev name in warning if no parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CBD3F7E@AcuExch.aculab.com>
Date:	Tue, 17 Nov 2015 09:44:27 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Bjørn Mork' <bjorn@...k.no>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net/core: use netdev name in warning if no parent

From: Bjørn Mork
> Sent: 16 November 2015 18:17
> A recent flaw in the netdev feature setting resulted in warnings
> like this one from VLAN interfaces:
> 
>  WARNING: CPU: 1 PID: 4975 at net/core/dev.c:2419 skb_warn_bad_offload+0xbc/0xcb()
>  : caps=(0x00000000001b5820, 0x00000000001b5829) len=2782 data_len=0 gso_size=1348 gso_type=16
> ip_summed=3
> 
> The ":" is supposed to be preceded by a driver name, but in this
> case it is an empty string since the device has no parent.
...

There'll also be no name if skb->dev is NULL.
There may not be anything interesting to print instead, but something
other than "" would be more useful.

	David