netdev - Re: [PATCH] iproute2: Ignore EADDRNOTAVAIL errors during address flush operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151123155939.6664468d@xeon-e3>
Date:	Mon, 23 Nov 2015 15:59:39 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Neil Horman <nhorman@...driver.com>
Cc:	netdev@...r.kernel.org, Alexey Kuznetsov <kuznet@....inr.ac.ru>
Subject: Re: [PATCH] iproute2: Ignore EADDRNOTAVAIL errors during address
 flush operation

On Thu,  5 Nov 2015 14:54:17 -0500
Neil Horman <nhorman@...driver.com> wrote:

> I found recently that, if I disabled address promotion in the kernel, that
> ip addr flush dev <dev>
> 
> would fail with an EADDRNOTAVAIL errno (though the flush operation would in fact
> flush all addresses from an interface properly)
> 
> Whats happening is that, if I add a primary and multiple secondary addresses to
> an interface, the flush operation first ennumerates them all with a GETADDR |
> DUMP operation, then sends a delete request for each address.  But the kernel,
> having promotion disabled, deletes all secondary addresses when the primary is
> removed.  That means, that several delete requests may still be pending in the
> netlink request for addresses that have been removed on our behalf, resulting in
> EADDRNOTAVAIL return codes.
> 
> It seems the simplest thing to do is to understand that EADDRUNAVAIL isn't a
> fatal outcome on a flush operation, as it just indicates that an address which
> you want to remove is already removed, so it can safely be ignored.
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>
> CC: Stephen Hemminger <stephen@...workplumber.org>
> CC: Alexey Kuznetsov <kuznet@....inr.ac.ru>

Applied, thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html