netdev - Re: [iproute PATCH 00/12] smaller iptunnel and ip6tunnel review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151123152857.3d733d97@xeon-e3>
Date:	Mon, 23 Nov 2015 15:28:57 -0800
From:	Stephen Hemminger <shemming@...cade.com>
To:	Phil Sutter <phil@....cc>
CC:	<netdev@...r.kernel.org>
Subject: Re: [iproute PATCH 00/12] smaller iptunnel and ip6tunnel review

On Fri, 13 Nov 2015 18:08:53 +0100
Phil Sutter <phil@....cc> wrote:

> In an effort to try and merge iptunnel and ip6tunnel support code, I found a
> few things worth changing, mainly by comparing the two files.
> 
> Please note that I did not test functionality of all supported tunnel modes,
> but since the changes are fairly small and obvious I hopefully didn't introduce
> too many bugs.
> 
> Phil Sutter (12):
>   ip{,6}tunnel: get rid of extraneous whitespace when printing
>   ip/tunnel: introduce tnl_parse_key()
>   ip{,6}tunnel: unify behaviour if physical device is not found
>   iptunnel: use ll_name_to_index() for physical interface lookup
>   ip{,6}tunnel: align do_tunnels_list() a bit
>   ip6tunnel: print local/remote addresses like iptunnel does
>   ip6tunnel: fix coding style: no newline between brace and else
>   iptunnel: share common code when setting tunnel mode
>   iptunnel: simplify parsing TTL, allow 'hlim' as identifier
>   iptunnel: share common code when determining the default interface
>     name
>   iptunnel: sanitize copying tunnel name
>   ip{,6}tunnel: put spaces around non-unary operators
> 
>  ip/ip6tunnel.c |  83 +++++++-------------
>  ip/iptunnel.c  | 239 ++++++++++++++++++++++-----------------------------------
>  ip/tunnel.c    |  15 ++++
>  ip/tunnel.h    |   1 +
>  4 files changed, 135 insertions(+), 203 deletions(-)
> 

Sure these all make sense. Applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html