netdev - RE: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head room in the skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Nov 2015 16:27:52 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Vitaly Kuznetsov <vkuznets@...hat.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>
Subject: RE: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head
 room in the skb



> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
> Sent: Tuesday, November 24, 2015 12:56 AM
> To: KY Srinivasan <kys@...rosoft.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; devel@...uxdriverproject.org; olaf@...fle.de;
> apw@...onical.com; jasowang@...hat.com
> Subject: Re: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head
> room in the skb
> 
> "K. Y. Srinivasan" <kys@...rosoft.com> writes:
> 
> > The rndis header is 116 bytes big and can be placed in the default
> > head room that will be available in the skb.
> 
> We have the following in include/linux/netdevice.h:
> 
> #if defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25)
> # if defined(CONFIG_MAC80211_MESH)
> #  define LL_MAX_HEADER 128
> # else
> #  define LL_MAX_HEADER 96
> # endif
> #else
> # define LL_MAX_HEADER 32
> #endif
> 
> In case someone disables MAC80211_MESH in his kernel config we're in
> troubles again. I suggest we add additional patch here making sure it is
> 128 bytes for Hyper-V:
> 
> #if defined(CONFIG_HYPERV_NET)
> # define LL_MAX_HEADER 128
> #elseif defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25)
> ...

Thanks Vitaly; will do.

K. Y
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html