netdev - RE: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head room in the skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLUPR0301MB1651609A4BBA4B1FC2DA44FEA0060@BLUPR0301MB1651.namprd03.prod.outlook.com>
Date:	Tue, 24 Nov 2015 16:39:51 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Florian Westphal <fw@...len.de>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>
Subject: RE: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head
 room in the skb



> -----Original Message-----
> From: Florian Westphal [mailto:fw@...len.de]
> Sent: Tuesday, November 24, 2015 12:56 AM
> To: KY Srinivasan <kys@...rosoft.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; devel@...uxdriverproject.org; olaf@...fle.de;
> apw@...onical.com; jasowang@...hat.com
> Subject: Re: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head
> room in the skb
> 
> K. Y. Srinivasan <kys@...rosoft.com> wrote:
> > The rndis header is 116 bytes big and can be placed in the default
> > head room that will be available in the skb. Since the netvsc packet
> > is less than 48 bytes, we can use the skb control buffer
> > for the netvsc packet. With these changes we don't need to
> > ask for additional head room.
> 
> Minor nit: could you add a BUILD_BUG_ON test for this?  Something like
> 
> BUILD_BUG_ON(sizeof(struct hv_netvsc_packet) > FIELD_SIZEOF(struct
> sk_buff, cb));

Good point; will add this check.

Thanks,

K. Y
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html