netdev - Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151125163402.GA29094@leverpostej>
Date:	Wed, 25 Nov 2015 16:34:02 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, isubramanian@....com, kchudgar@....com,
	linux-kernel@...r.kernel.org, ryabinin.a.a@...il.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2

On Wed, Nov 25, 2015 at 08:17:36AM -0800, Eric Dumazet wrote:
> On Wed, 2015-11-25 at 15:59 +0000, Mark Rutland wrote:
> > xgene_enet_start_xmit
> 
> Please try following trivial fix

With that applied KASAN is silent, despite my efforts to trigger the
issue, so it looks like that fixes it.

Thanks,
Mark.

> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index 1adfe7036843..9147a0107c44 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -450,12 +450,12 @@ static netdev_tx_t xgene_enet_start_xmit(struct sk_buff *skb,
>  		return NETDEV_TX_OK;
>  	}
>  
> -	pdata->ring_ops->wr_cmd(tx_ring, count);
>  	skb_tx_timestamp(skb);
>  
>  	pdata->stats.tx_packets++;
>  	pdata->stats.tx_bytes += skb->len;
>  
> +	pdata->ring_ops->wr_cmd(tx_ring, count);
>  	return NETDEV_TX_OK;
>  }
>  
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html