netdev - Re: [net-next 12/15] i40evf: fix compiler warning of unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5657114F.2020009@cogentembedded.com>
Date:	Thu, 26 Nov 2015 17:03:59 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
Cc:	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
	jogreene@...hat.com
Subject: Re: [net-next 12/15] i40evf: fix compiler warning of unused variable

Hello.

On 11/23/2015 10:36 PM, Jeff Kirsher wrote:

> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
>
> Compiler complained of an unused variable, which the driver was just
> using to store the result of a rd32 which is used to clear a register
> unconditionally.  Just drop the unused variable and re-use one.

   I don't see Jesse dropping anything...

> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>   drivers/net/ethernet/intel/i40evf/i40evf_main.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> index d962164..6ad6265 100644
> --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> @@ -307,10 +307,9 @@ static irqreturn_t i40evf_msix_aq(int irq, void *data)
>   	struct i40e_hw *hw = &adapter->hw;
>   	u32 val;
>
> -	/* handle non-queue interrupts */
> -	rd32(hw, I40E_VFINT_ICR01);
> -	rd32(hw, I40E_VFINT_ICR0_ENA1);
> -
> +	/* handle non-queue interrupts, these reads clear the registers */
> +	val = rd32(hw, I40E_VFINT_ICR01);
> +	val = rd32(hw, I40E_VFINT_ICR0_ENA1);

    Why if it's ignored anyway?

>
>   	val = rd32(hw, I40E_VFINT_DYN_CTL01) |
>   	      I40E_VFINT_DYN_CTL01_CLEARPBA_MASK;


MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html