netdev - Re: [net-next 07/15] ixgbe: Fix handling of NAPI budget when multiple queues are enabled per vector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ75kXZfRUtOvsJtPpbT3JSJwrVO_sY=ePe9MHE0sLj1k1JNtQ@mail.gmail.com>
Date:	Fri, 27 Nov 2015 09:25:34 +0100
From:	William Dauchy <wdauchy@...il.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Alexander Duyck <aduyck@...antis.com>,
	NETDEV <netdev@...r.kernel.org>, nhorman@...hat.com,
	sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next 07/15] ixgbe: Fix handling of NAPI budget when multiple
 queues are enabled per vector

Hello Jeff,

There is also the equivalent patch for ixgbevf
http://patchwork.ozlabs.org/patch/539065/


On Mon, Nov 23, 2015 at 8:36 PM, Jeff Kirsher
<jeffrey.t.kirsher@...el.com> wrote:
> From: Alexander Duyck <aduyck@...antis.com>
>
> This patch corrects an issue in which the polling routine would increase
> the budget for Rx to at least 1 per queue if multiple queues were present.
> This would result in Rx packets being processed when the budget was 0 which
> is meant to indicate that no Rx can be handled.
>
> Signed-off-by: Alexander Duyck <aduyck@...antis.com>
> Tested-by: Darin Miller <darin.j.miller@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index c9b7e5e..4fa94a3 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -2783,7 +2783,8 @@ int ixgbe_poll(struct napi_struct *napi, int budget)
>         ixgbe_for_each_ring(ring, q_vector->tx)
>                 clean_complete &= !!ixgbe_clean_tx_irq(q_vector, ring);
>
> -       if (!ixgbe_qv_lock_napi(q_vector))
> +       /* Exit if we are called by netpoll or busy polling is active */
> +       if ((budget <= 0) || !ixgbe_qv_lock_napi(q_vector))
>                 return budget;
>
>         /* attempt to distribute budget to each queue fairly, but don't allow
> --
> 2.5.0

-- 
William
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html