netdev - Re: [PATCH] xprtrdma: add missing curly braces, set rc to zero on non-zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <565F0E2F.7070301@Netapp.com>
Date:	Wed, 2 Dec 2015 10:28:47 -0500
From:	Anna Schumaker <Anna.Schumaker@...app.com>
To:	Colin King <colin.king@...onical.com>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	"J . Bruce Fields" <bfields@...ldses.org>,
	Jeff Layton <jlayton@...chiereds.net>,
	"David S . Miller" <davem@...emloft.net>,
	Chuck Lever <chuck.lever@...cle.com>,
	Sagi Grimberg <sagig@...lanox.com>,
	Steve Wise <swise@...ngridcomputing.com>,
	Doug Ledford <dledford@...hat.com>,
	<linux-nfs@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xprtrdma: add missing curly braces, set rc to zero on
 non-zero

On 11/24/2015 06:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Add the missing curly braces so that rc is only set to zero when
> it is non-zero.  Without this minor fix, rc is set to zero even
> when it is zero, which is slightly redundant.
> 
> Detected with smatch static analysis.

Thanks for the patch, but I've already have a patch from Dan Carpenter queued up to fix this.

Anna

> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  net/sunrpc/xprtrdma/verbs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index eadd1655..2cc1014 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -852,10 +852,11 @@ retry:
>  
>  		if (extras) {
>  			rc = rpcrdma_ep_post_extra_recv(r_xprt, extras);
> -			if (rc)
> +			if (rc) {
>  				pr_warn("%s: rpcrdma_ep_post_extra_recv: %i\n",
>  					__func__, rc);
>  				rc = 0;
> +			}
>  		}
>  	}
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html