netdev - Re: [RFC PATCH net] vxlan: fix incorrect RCO bit in VXLAN header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151205.181603.662890672788412924.davem@davemloft.net>
Date:	Sat, 05 Dec 2015 18:16:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, tgraf@...g.ch, therbert@...gle.com
Subject: Re: [RFC PATCH net] vxlan: fix incorrect RCO bit in VXLAN header

From: Jiri Benc <jbenc@...hat.com>
Date: Fri,  4 Dec 2015 13:54:03 +0100

> Commit 3511494ce2f3d ("vxlan: Group Policy extension") changed definition of
> VXLAN_HF_RCO from 0x00200000 to BIT(24). This is obviously incorrect. It's
> also in violation with the RFC draft.
> 
> Fixes: 3511494ce2f3d ("vxlan: Group Policy extension")
> Cc: Thomas Graf <tgraf@...g.ch>
> Cc: Tom Herbert <therbert@...gle.com>
> Signed-off-by: Jiri Benc <jbenc@...hat.com>
> ---
> This code is, unfortunately, in the tree since 4.0. Not sure whether we can
> change it now. On the other hand, we're in violation with the RFC draft and
> collide with VXLAN-GPE flags assignment which defines this bit as OAM flag.
> 
> Opinions welcome, especially by Tom and Thomas.

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html