netdev - Re: [PATCH net] sctp: only drop the reference on the datamsg after sending a msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151206.132603.1391902857457071088.davem@davemloft.net>
Date:	Sun, 06 Dec 2015 13:26:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	lucien.xin@...il.com
Cc:	netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
	marcelo.leitner@...il.com, vyasevic@...hat.com
Subject: Re: [PATCH net] sctp: only drop the reference on the datamsg after
 sending a msg

From: Xin Long <lucien.xin@...il.com>
Date: Sat,  5 Dec 2015 15:19:27 +0800

> If the chunks are enqueued successfully but sctp_cmd_interpreter()
> return err to sctp_sendmsg() (mainly because of no mem), the chunks will
> get re-queued, but we are dropping the reference and freeing them.
> 
> The fix is to just drop the reference on the datamsg just as it had
> succeeded, as:
>  - if the chunks weren't queued, this is enough to get them freed.
>  - if they were queued, they will get freed when they finally get out or
>  discarded.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html