netdev - Re: [PATCH net] geneve: Fix IPv6 xmit stats update.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+r=Gvh-FD12o-SmPONACs1O9TSzemg37Hk5-5g-hW6afw@mail.gmail.com>
Date:	Tue, 8 Dec 2015 09:55:58 -0800
From:	Pravin Shelar <pshelar@...ira.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] geneve: Fix IPv6 xmit stats update.

On Tue, Dec 8, 2015 at 6:54 AM, John W. Linville <linville@...driver.com> wrote:
> On Mon, Dec 07, 2015 at 07:17:30PM -0800, Pravin B Shelar wrote:
>> Call to iptunnel_xmit_stats() is not required after udp-tunnel6-xmit.
>> By calling iptunnel_xmit_stats() results in incorrect device stats.
>> Following patch drops this call.
>>
>> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
>> ---
>>  drivers/net/geneve.c |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
>> index de5c30c..c2b79f5 100644
>> --- a/drivers/net/geneve.c
>> +++ b/drivers/net/geneve.c
>> @@ -967,8 +967,6 @@ static netdev_tx_t geneve6_xmit_skb(struct sk_buff *skb, struct net_device *dev,
>>       err = udp_tunnel6_xmit_skb(dst, gs6->sock->sk, skb, dev,
>>                                  &fl6.saddr, &fl6.daddr, prio, ttl,
>>                                  sport, geneve->dst_port, !udp_csum);
>> -
>> -     iptunnel_xmit_stats(err, &dev->stats, dev->tstats);
>>       return NETDEV_TX_OK;
>>
>>  tx_error:
>
> So udp_tunnel_xmit_skb and udp_tunnel6_xmit_skb are different in this
> regard? It seems so -- who knew? :-)
>
> _Should_ they be different in this regard?
>

I am planing on sending a patch to make these APIs consistent.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html