netdev - Re: rhashtable: Enforce minimum size on initial hash table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151216.104508.256133184136757332.davem@davemloft.net>
Date:	Wed, 16 Dec 2015 10:45:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	william.hua@...onical.com, netdev@...r.kernel.org, tgraf@...g.ch
Subject: Re: rhashtable: Enforce minimum size on initial hash table

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 16 Dec 2015 18:13:14 +0800

> William Hua <william.hua@...onical.com> wrote:
>>
>> I wasn't aware there was an enforced minimum size. I simply set the 
>> nelem_hint in the rhastable_params struct to 1, expecting it to grow as
>> needed. This caused a segfault afterwards when trying to insert an
>> element.
> 
> OK we're doing the size computation before we enforce the limit
> on min_size.
> 
> ---8<---
> We need to do the initial hash table size computation after we
> have obtained the correct min_size/max_size parameters.  Otherwise
> we may end up with a hash table whose size is outside the allowed
> envelope.
> 
> Fixes: a998f712f77e ("rhashtable: Round up/down min/max_size to...")
> Reported-by: William Hua <william.hua@...onical.com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html