netdev - Re: [PATCH v7 0/4] Support administratively closing application sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1450281013.8474.73.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 16 Dec 2015 07:50:13 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Lorenzo Colitti <lorenzo@...gle.com>, netdev@...r.kernel.org,
	davem@...emloft.net, hannes@...essinduktion.org, ek@...gle.com,
	tom@...bertland.com, zenczykowski@...il.com
Subject: Re: [PATCH v7 0/4] Support administratively closing application
 sockets

On Wed, 2015-12-16 at 07:43 -0800, Stephen Hemminger wrote:

> 
> I see no security checks in the diag infrastructure.
> Up until now diag has been read-only access and therefore has been
> allowed for all users.

It is still allowed to all users.

Only the 'destroy' operation is restricted.


+int sock_diag_destroy(struct sock *sk, int err)
+{
+       if (!ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN))
+               return -EPERM;
+
+       if (!sk->sk_prot->diag_destroy)
+               return -EOPNOTSUPP;
+
+       return sk->sk_prot->diag_destroy(sk, err);
+}
+EXPORT_SYMBOL_GPL(sock_diag_destroy);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html