netdev - [patch] poll.2: timeout_ts is a pointer, so use -> not . for member access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO_2OxVnn4cmvX5fZmXYHgW6v3aoH=OAGrk62QgrTA=qYrrcew@mail.gmail.com>
Date:	Wed, 23 Dec 2015 13:30:29 -0600
From:	"richardvoigt@...il.com" <richardvoigt@...il.com>
To:	mtk.manpages@...il.com
Cc:	linux-man@...r.kernel.org, netdev@...r.kernel.org
Subject: [patch] poll.2: timeout_ts is a pointer, so use -> not . for member access

>From the context, it is apparent that in the code explaining ppoll in
terms of poll, timeout_ts must be a pointer.

Usage #1:   ready = ppoll(&fds, nfds, timeout_ts, &sigmask);

Usage #2:    (timeout_ts == NULL)

Thus member access in (timeout_ts.tv_sec * 1000 + timeout_ts.tv_nsec /
1000000) is an error.

Ben



man2/poll.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man2/poll.2 b/man2/poll.2
index bcbecad..34b55a6 100644
--- a/man2/poll.2
+++ b/man2/poll.2
@@ -266,7 +266,7 @@ executing the following calls:
     int timeout;

     timeout = (timeout_ts == NULL) ? \-1 :
-              (timeout_ts.tv_sec * 1000 + timeout_ts.tv_nsec / 1000000);
+              (timeout_ts\->tv_sec * 1000 + timeout_ts\->tv_nsec / 1000000);
     pthread_sigmask(SIG_SETMASK, &sigmask, &origmask);
     ready = poll(&fds, nfds, timeout);
     pthread_sigmask(SIG_SETMASK, &origmask, NULL);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html