netdev - Re: [patch] poll.2: timeout_ts is a pointer, so use -> not . for member access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKgNAkgQS2ifFhP+Z2mQM1ryTNCzUzdV6Jc=oPg-kCZs-GA4OA@mail.gmail.com>
Date:	Wed, 23 Dec 2015 23:29:13 +0100
From:	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:	"richardvoigt@...il.com" <richardvoigt@...il.com>
Cc:	linux-man <linux-man@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [patch] poll.2: timeout_ts is a pointer, so use -> not . for
 member access

Hello Richard,

On 23 December 2015 at 20:30, richardvoigt@...il.com
<richardvoigt@...il.com> wrote:
> From the context, it is apparent that in the code explaining ppoll in
> terms of poll, timeout_ts must be a pointer.
>
> Usage #1:   ready = ppoll(&fds, nfds, timeout_ts, &sigmask);
>
> Usage #2:    (timeout_ts == NULL)
>
> Thus member access in (timeout_ts.tv_sec * 1000 + timeout_ts.tv_nsec /
> 1000000) is an error.

Thanks. Patch applied.

Cheers,

Michael


> man2/poll.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man2/poll.2 b/man2/poll.2
> index bcbecad..34b55a6 100644
> --- a/man2/poll.2
> +++ b/man2/poll.2
> @@ -266,7 +266,7 @@ executing the following calls:
>      int timeout;
>
>      timeout = (timeout_ts == NULL) ? \-1 :
> -              (timeout_ts.tv_sec * 1000 + timeout_ts.tv_nsec / 1000000);
> +              (timeout_ts\->tv_sec * 1000 + timeout_ts\->tv_nsec / 1000000);
>      pthread_sigmask(SIG_SETMASK, &sigmask, &origmask);
>      ready = poll(&fds, nfds, timeout);
>      pthread_sigmask(SIG_SETMASK, &origmask, NULL);



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html