lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Dec 2015 16:51:50 -0500 From: "David Rivshin (Allworx)" <drivshin.allworx@...il.com> To: Markus Brunner <systemprogrammierung.brunner@...il.com>, Grygorii Strashko <grygorii.strashko@...com> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org, devicetree@...r.kernel.org, hs@...x.de, mugunthanvnm@...com, kernel@...ek.de, dtrautmann@...softec-sps.de Subject: Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes On Wed, 23 Dec 2015 19:35:37 +0100 Markus Brunner <systemprogrammierung.brunner@...il.com> wrote: > On Wednesday 23 December 2015 12:04:25 David Miller wrote: > > From: "David Rivshin (Allworx)" <drivshin.allworx@...il.com> > > Date: Tue, 22 Dec 2015 19:36:31 -0500 > > > > > Testing by anyone who has real hardware using phy-handle or > > > dual_emac with fixed-link would be appreciated. > > > > I'm going to wait for such testing before applying this series. > > > > Thanks. > > Successfully tested the following 3 configurations. > 1. emac0 with phy_id and emac1 with fixed phy > 2. emac0 with phy-handle and emac1 with fixed phy > 3. emac0 with fixed phy and emac1 with fixed phy Great, thanks for testing. Using the same technique for the phy-handle case as you, I also just tested: - (EVMSK) dual emac, phy-handle property in both slaves I think that covers all the interesting cases. Dave, I actually just received a note off-list reporting a problem with this series on the dm8148-t410 board. So please hold off applying this series for now. If it turns out to be a real problem I'll have a v2. [...] > &davinci_mdio { > status = "okay"; > phy0: ethernet-phy@0 { > reg = <5>; > }; > }; I was unaware that the davinci-mdio driver creates PHY devices from child nodes. The davinci-mdio.txt binding documentation makes no mention of that. By comparison the emac_rockchip.txt file does talk about it. Now that I take a closer look at the code, it looks like that capability was added in commit 0a0ea0687281 ("net: davinci_mdio: allow to create phys from dt"), but it didn't update the binding. Grygorii, was that just an oversight, or capability that's not supposed to be used? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists