netdev - Re: [PATCH 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151229203034.GA18528@rob-hp-laptop>
Date:	Tue, 29 Dec 2015 14:30:34 -0600
From:	Rob Herring <robh@...nel.org>
To:	"David Rivshin (Allworx)" <drivshin.allworx@...il.com>
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	Heiko Schocher <hs@...x.de>,
	Mugunthan V N <mugunthanvnm@...com>,
	Markus Brunner <systemprogrammierung.brunner@...il.com>,
	Pascal Speck <kernel@...ek.de>,
	Daniel Trautmann <dtrautmann@...softec-sps.de>
Subject: Re: [PATCH 2/3] drivers: net: cpsw: fix error messages when using
 phy-handle DT property

On Tue, Dec 22, 2015 at 07:36:33PM -0500, David Rivshin (Allworx) wrote:
> From: David Rivshin <drivshin@...worx.com>
> 
> The phy-handle, phy_id, and fixed-link properties are mutually exclusive,
> and only one need be specified. However if phy-handle was specified, an
> error message would complain about the lack of phy_id or fixed-link.
> 
> Also, if phy-handle was specified and the subsequent of_phy_connect()
> failed, the error message still referenced slaved->data->phy_id, which
> would be empty. Instead, use the name of the device_node as a useful
> identifier.
> 
> Fixes: 9e42f715264f ("drivers: net: cpsw: add phy-handle parsing")
> Signed-off-by: David Rivshin <drivshin@...worx.com>
> ---
> This would require some adjustments to backport to 4.3-stable due to
> other changes in this area. Let me know if you want a version of this
> against v4.3.3.
> 
>  Documentation/devicetree/bindings/net/cpsw.txt |  4 ++--

For the binding:

Acked-by: Rob Herring <robh@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html