[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <EEE79716-61A1-403E-826D-198C21667070@gmail.com>
Date: Sun, 27 Dec 2015 12:07:15 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
CC: netdev <netdev@...r.kernel.org>
Subject: Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats
On December 27, 2015 3:58:25 AM PST, Andrew Lunn <andrew@...n.ch> wrote:
>This patchset add ethtool support for reading statistics from the PHY.
>The Marvell and Micrel Phys are then extended to report receiver
>packet errors and idle errors.
Reviewed-by: Florian Fainelli <f.faibelli@...il.com>
This is very useful, thanks! I like that you have introduced a separate interface rather than forcing the use of the existing get statistics method and then overlaying PHY stats to the existing MAC stats, this is just cleaner.
>
>v2:
> Fix linking when phylib is not enabled.
>
>Andrew Lunn (3):
> ethtool: Add phy statistics
> phy: marvell: Add ethtool statistics counters
> phy: micrel: Add ethtool statistics counters
>
>drivers/net/phy/marvell.c | 135
>+++++++++++++++++++++++++++++++++++++++++++
> drivers/net/phy/micrel.c | 96 ++++++++++++++++++++++++++++++
> drivers/net/phy/phy.c | 35 +++++++++++
> include/linux/phy.h | 11 +++-
> include/uapi/linux/ethtool.h | 3 +
> net/core/ethtool.c | 57 +++++++++++++++++-
> 6 files changed, 335 insertions(+), 2 deletions(-)
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists