netdev - Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Dec 2015 21:12:23 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats

On Sun, Dec 27, 2015 at 12:07:15PM -0800, Florian Fainelli wrote:
> On December 27, 2015 3:58:25 AM PST, Andrew Lunn <andrew@...n.ch> wrote:
> >This patchset add ethtool support for reading statistics from the PHY.
> >The Marvell and Micrel Phys are then extended to report receiver
> >packet errors and idle errors.
> 
> Reviewed-by: Florian Fainelli <f.faibelli@...il.com>
> 

> This is very useful, thanks! I like that you have introduced a
> separate interface rather than forcing the use of the existing get
> statistics method and then overlaying PHY stats to the existing MAC
> stats, this is just cleaner.

I started out by extending the MAC stats, but the code was ugly
dealing with the different cases and MAC and PHY statistics. This way
is a lot cleaner.

   Andrew
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html