netdev - Re: [PATCH] af_unix: Fix splice-bind deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vb7ak08l.fsf@doppelsaurus.mobileactivedefense.com>
Date:	Sun, 03 Jan 2016 18:04:58 +0000
From:	Rainer Weikusat <rweikusat@...ileactivedefense.com>
To:	David Miller <davem@...emloft.net>
Cc:	<dvyukov@...gle.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <viro@...IV.linux.org.uk>
Subject: Re: [PATCH] af_unix: Fix splice-bind deadlock

Rainer Weikusat <rw@...pelsaurus.mobileactivedefense.com> writes:

[...]

> +	dentry = NULL;
> +	if (sun_path[0]) {
> +		/* Get the parent directory, calculate the hash for last
> +		 * component.
> +		 */
> +		dentry = kern_path_create(AT_FDCWD, sun_path, &path, 0);
> +
> +		err = PTR_ERR(dentry);
> +		if (IS_ERR(dentry))
> +			goto out;
> +	}
> +

This is wrong because kern_path_create can return with -EEXIST which
needs to be translated to -EADDRINUSE for this case. I'll fix that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html