netdev - [PATCH iproute2 v2 1/2] arpd: drop unnecessary explicit null termination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1451846374-2665-1-git-send-email-andreas@fatal.se>
Date:	Sun,  3 Jan 2016 19:39:32 +0100
From:	Andreas Henriksson <andreas@...al.se>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org, Andreas Henriksson <andreas@...al.se>
Subject: [PATCH iproute2 v2 1/2] arpd: drop unnecessary explicit null termination

This is a followup to a previous commit 61170fd88d264c
"get rid of unnecessary fgets() buffer size limitation".

If fgets guarantees buffer will be null terminated in the
given size, then we can also drop the explicit termination.

Signed-off-by: Andreas Henriksson <andreas@...al.se>
---
 misc/arpd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/misc/arpd.c b/misc/arpd.c
index 6bb9bd1..700dc50 100644
--- a/misc/arpd.c
+++ b/misc/arpd.c
@@ -702,7 +702,6 @@ int main(int argc, char **argv)
 			goto do_abort;
 		}
 
-		buf[sizeof(buf)-1] = 0;
 		while (fgets(buf, sizeof(buf), fp)) {
 			__u8 b1[6];
 			char ipbuf[128];
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html